perf: Update moe_token_dispatcher_type default to alltoall#2004
perf: Update moe_token_dispatcher_type default to alltoall#2004parthmannan wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
📝 WalkthroughWalkthroughThe PR updates Megatron MoE token dispatcher configuration from "allgather" to "alltoall" across example configuration files, test files, and documentation, changing the distributed token routing strategy. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nemo_rl/models/policy/__init__.py (1)
1-1:⚠️ Potential issue | 🟡 MinorUpdate the copyright year to 2026.
The file was modified but the header still shows 2025; update it to the current year.
🔧 Suggested fix
-# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. +# Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved.As per coding guidelines: Add the NVIDIA copyright header (with current year) to all Python files and shell scripts, excluding tests (files under
tests/or test-only scripts).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nemo_rl/models/policy/__init__.py` at line 1, Replace the outdated copyright year in the top-of-file header comment from 2025 to 2026; locate the header comment at the beginning of the module (the copyright comment line in nemo_rl/models/policy/__init__.py) and update the year to "2026" so the NVIDIA copyright header is current.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@nemo_rl/models/policy/__init__.py`:
- Line 1: Replace the outdated copyright year in the top-of-file header comment
from 2025 to 2026; locate the header comment at the beginning of the module (the
copyright comment line in nemo_rl/models/policy/__init__.py) and update the year
to "2026" so the NVIDIA copyright header is current.
90a737d to
493ddef
Compare
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit