Use TorchX main from GitHub with dependency compatibility fixes#429
Open
hemildesai wants to merge 4 commits intomainfrom
Open
Use TorchX main from GitHub with dependency compatibility fixes#429hemildesai wants to merge 4 commits intomainfrom
hemildesai wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
ko3n1g
reviewed
Feb 24, 2026
| "fabric>=3.2.2", | ||
| "fiddle>=0.3.0", | ||
| "torchx>=0.7.0", | ||
| "torchx @ git+https://github.com/meta-pytorch/torchx.git@main", |
Contributor
There was a problem hiding this comment.
This breaks PyPi compatibility. We can use uv.sources to override with a vcs dependency in uv-environments only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torchxdependency to GitHubmain(git+https://github.com/meta-pytorch/torchx.git@main)cryptography<43pin and keepcryptographyas a normal dependencycryptographyandurllib3>=2.6.3importlib-metadatadependency (was previously only transitive)main:nemo_run/run/logs.py: supporttorchx.util.colorswith fallback to legacy modulenemo_run/run/torchx_backend/runner.py: support new_validate(..., cfg)signature with backward compatibilityuv.lock(TorchX now resolves from commit029982c43d3b94a013be322d78d5dd2246542fe0)Validation
uv sync --extra skypilotsucceeds and installs TorchX from GitHub mainuv run --group lint -- ruff checkpassesuv run --group lint -- ruff format --diffpassesuv run pytest test/run/test_experiment.py::test_experiment_dryrun_with_cleanup test/run/torchx_backend/test_api.py::test_run_dryrun_with_executor test/run/test_logs.pyuv run -- coverage run --branch --source=nemo_run -a -m pytesttest_concatenate_tar_files_non_linux_integration) includes._*files