chore: enable volume extra test

[mckornfield]

• Also fix nss test

Summary by CodeRabbit

• New Features

  • Added shared persistent storage support for Kubernetes and Volcano jobs in E2E environments, mounted at /mnt/additional_storage.
  • Enabled additional-volume job coverage when the required storage is available.

• Tests

  • Improved Safe Synthesizer test setup by creating model filesets directly and validating the expected fileset count.
  • E2E tests now conditionally skip storage-dependent scenarios when the required mount is unavailable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 76379e7a-8c29-49cb-9229-8d9add57bc7b

📥 Commits

Reviewing files that changed from the base of the PR and between 8a5663f and b254027.

📒 Files selected for processing (7)

• e2e/k8s/values/default.yaml
• e2e/k8s/values/kind.yaml
• e2e/k8s/values/minikube-auth-portforward.yaml
• e2e/k8s/values/minikube-auth.yaml
• e2e/k8s/values/minikube.yaml
• e2e/test_jobs.py
• e2e/test_safe_synthesizer.py

---

📝 Walkthrough

Walkthrough

E2E Kubernetes and Volcano jobs now mount a PVC-backed volume at /mnt/additional_storage. The additional-volume test conditionally skips based on service configuration. Safe Synthesizer fileset setup now uses in-process module loading with count validation.

Changes

E2E job storage

Layer / File(s)	Summary
PVC-backed job storage configuration e2e/k8s/values/*.yaml	Kubernetes and Volcano job executors are configured with nmp-additional-volume, backed by the chart PVC template and mounted at /mnt/additional_storage.
Conditional additional-volume validation e2e/test_jobs.py	The additional-volume test receives RunningServices and skips only when the required container-backed mount is unavailable.

Safe Synthesizer fileset setup

Layer / File(s)	Summary
In-process model-fileset registration e2e/test_safe_synthesizer.py	The fixture dynamically loads setup_model_filesets.py, invokes create_filesets, validates the created-fileset count, and removes subprocess-specific handling.

Possibly related PRs

• NVIDIA-NeMo/nemo-platform#654: Both changes modify Safe Synthesizer model-fileset registration in e2e/test_safe_synthesizer.py.
• NVIDIA-NeMo/nemo-platform#691: Both changes rework the Safe Synthesizer fileset setup flow.

Suggested labels: test

Suggested reviewers: matthewgrossman, tylersbray

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: enabling the additional-volume E2E test, though the phrasing is awkward.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jobs-reenable-volume-test/mck

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	25531/32732	78.0%	62.6%
Integration Tests	14729/31381	46.9%	19.2%