Skip to content

fix(studio): Add a model dropdown for Base Model filtering on the Virtual Model Grid#755

Open
htolentino-nvidia wants to merge 1 commit into
mainfrom
ASTD-307-fix-base-model-filters/htolentino
Open

fix(studio): Add a model dropdown for Base Model filtering on the Virtual Model Grid#755
htolentino-nvidia wants to merge 1 commit into
mainfrom
ASTD-307-fix-base-model-filters/htolentino

Conversation

@htolentino-nvidia

@htolentino-nvidia htolentino-nvidia commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

https://linear.app/nvidia/issue/ASTD-307/virtual-models-default-model-filter-is-a-free-text-input-with-no

Summary by CodeRabbit

  • New Features

    • Added a dedicated “Default Model” filter with single-select search behavior.
  • Bug Fixes

    • Improved filtering accuracy by matching the selected default model exactly.
    • Ensured model-related column displays stay synchronized with the current workspace.

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia requested review from a team as code owners July 17, 2026 15:15
@htolentino-nvidia htolentino-nvidia changed the title Add a model dropdown for Base Model filtering on the Virtual Model Grid fix(studio): Add a model dropdown for Base Model filtering on the Virtual Model Grid Jul 17, 2026
@github-actions github-actions Bot added the fix label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f4d78ad0-a404-49b3-aa6a-99413e470599

📥 Commits

Reviewing files that changed from the base of the PR and between 8a5663f and 41226b0.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx

📝 Walkthrough

Walkthrough

VirtualModelsDataView replaces the Default Model text filter with a single-select model search field, applies exact $eq filtering, and includes workspace in column memoization dependencies.

Changes

Virtual model filtering

Layer / File(s) Summary
Default model filter integration
web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx
The Default Model column renders BaseModelSearchFilterField, stores one selected model or undefined, applies default_model_entity with $eq, and rebuilds columns when workspace changes.

Possibly related PRs

Suggested labels: feat

Suggested reviewers: shanaiabuggy

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a model dropdown for Base Model filtering in the Virtual Model Grid.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ASTD-307-fix-base-model-filters/htolentino

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25534/32732 78.0% 62.7%
Integration Tests 14730/31381 46.9% 19.3%

@steramae-nvidia steramae-nvidia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the change from $like to $eq?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants