feat(agents): external NAT agents — Studio UI (stacked on #763)#764
Draft
marcusds wants to merge 2 commits into
Draft
feat(agents): external NAT agents — Studio UI (stacked on #763)#764marcusds wants to merge 2 commits into
marcusds wants to merge 2 commits into
Conversation
- probe_agent_reachable streams and checks status only (no unbounded body read) - external chat honors the card's capabilities.streaming: a streaming request to a non-streaming agent uses message/send wrapped in one SSE chunk - streaming uses an incremental UTF-8 decoder so a multi-byte char split across network chunks isn't corrupted - streaming primes the first delta so a failure before any token returns 502; a mid-stream failure is logged and ends without a normal "stop" finish - the conversation prompt preserves system messages and anchors on the last user turn (drops trailing assistant) - managed-agent proxy no longer double-fetches the Agent entity Skipped (P2): full AgentCard schema validation — would require taking a2a-sdk as a runtime dep; cards stay loosely validated (operator-trust) and incompatible ones fail at invocation with a clear error. Signed-off-by: mschwab <mschwab@nvidia.com>
Studio support for external agents (registered by URL). Depends on the backend PR (#763): needs the source/endpoint/card Agent fields, config-XOR-url create, and the refresh/reachability endpoints. - Register modal: Connect running agent by endpoint URL (structural validation) - Agents table: External badge; onboarding empty state + NAT docs link - Agent panel: - Workflow tab — managed: config graph + YAML (credentials redacted); external: A2A card skills + endpoint - Chat playground wired to the external chat bridge (streaming, multi-turn) - Details: Source/Endpoint, reachability badge + Refresh card button - Deploy/Logs gated for external; Evaluate available (via bridge) - resolve the panel agent via GET /agents/{name} (not a page-1 list scan) - shared isExternalAgent predicate + ExternalAgentNotice Unit tests for read models + credential redaction; typecheck + lint clean. Signed-off-by: mschwab <mschwab@nvidia.com>
marcusds
force-pushed
the
register-external-agents-frontend/mschwab
branch
from
July 17, 2026 18:26
3112e34 to
95e1c7d
Compare
marcusds
force-pushed
the
register-external-agents-backend/mschwab
branch
2 times, most recently
from
July 17, 2026 19:18
4915ed8 to
e098344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Studio UI for external NAT agents (agents that run outside NeMo Platform, registered by URL).
What's included
Externalbadge; onboarding empty state + NAT docs link.GET /agents/{name}(not a page-1 list scan — external agents past page 1 were mis-rendered as managed).isExternalAgentpredicate +ExternalAgentNotice.Testing
Unit tests for the read models (
summarizeAgentCard,summarizeAgentWorkflow) + credential redaction; agent suites green; typecheck (our files) + lint clean.CI note
The
web-typecheckjob may fail on pre-existing intake/eval-session errors (Trace.input/output,@axe-core/playwright) authored onmain— untouched by this branch; clears when main's typecheck is fixed.🤖 Generated with Claude Code