refactor(studio): Bump KUI to 1.7.0#767
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
This change is part of the following stack: Change managed by git-spice. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughForm-controlled inputs now render with explicit props, input-file mapping uses the correct output field, Studio tests await asynchronous UI changes, and workspace dependency and formatting configuration were updated. ChangesForm UI behavior
Studio validation and tooling
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsx`:
- Around line 98-103: Update the TextArea and TextInput instances in
LLMJudgeInput to receive the corresponding controller field handlers directly:
wire field.onChange and field.onBlur alongside each field’s current value.
Preserve the existing error status, placeholders, and input configuration while
ensuring all three controls can update and validate their FormField values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: aa423b5d-6dd5-48e2-81d7-bd963acae5e2
📒 Files selected for processing (9)
web/packages/common/src/components/UploadModal/DatasetUploader/Select.tsxweb/packages/common/src/components/form/ControlledCheckbox/index.tsxweb/packages/common/src/components/form/ControlledCombobox/index.tsxweb/packages/common/src/components/form/ControlledRadioGroup/index.tsxweb/packages/studio/src/components/DatasetInputFile/index.tsxweb/packages/studio/src/components/evaluation/Configurations/form/InputFile/InputFileValidationBanner.tsxweb/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsxweb/packages/studio/src/components/evaluation/Configurations/form/MetricsCheckboxes.tsxweb/packages/studio/src/components/evaluation/Configurations/form/StringCheckInput.tsx
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit