Skip to content

refactor(studio): Bump KUI to 1.7.0#767

Open
steramae-nvidia wants to merge 6 commits into
mainfrom
steramae/kui-1.7
Open

refactor(studio): Bump KUI to 1.7.0#767
steramae-nvidia wants to merge 6 commits into
mainfrom
steramae/kui-1.7

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Sean Teramae steramae@nvidia.com

Summary by CodeRabbit

  • Bug Fixes
    • Made “Report a Trace” behave consistently as a selectable link when telemetry is enabled.
    • Fixed offline “Cached Output Key” mapping so the selected key is saved to the correct output setting.
  • Tests
    • Updated UI tests to wait for side-panel close and evaluation-job deletion updates before asserting results.
  • Refactor
    • Simplified several form/select and checkbox/radio integrations by removing render-prop prop forwarding.
  • Chores
    • Updated workspace dependency management settings and expanded formatting ignore rules.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners July 17, 2026 17:59
@steramae-nvidia

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e3005dd9-adba-4442-a136-d5c0a95a8c0a

📥 Commits

Reviewing files that changed from the base of the PR and between f5e3cec and bbe20e5.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsx

📝 Walkthrough

Walkthrough

Form-controlled inputs now render with explicit props, input-file mapping uses the correct output field, Studio tests await asynchronous UI changes, and workspace dependency and formatting configuration were updated.

Changes

Form UI behavior

Layer / File(s) Summary
Controlled component wiring
web/packages/common/src/components/UploadModal/DatasetUploader/Select.tsx, web/packages/common/src/components/form/*
Controlled dataset, checkbox, combobox, and radio-group components no longer forward render-prop arguments and retain explicit form-state bindings.
Evaluation configuration controls
web/packages/studio/src/components/DatasetInputFile/index.tsx, web/packages/studio/src/components/evaluation/Configurations/form/*
Dataset and evaluation controls now pass values and handlers explicitly; LLM judge fields use controlled components; cached output mapping writes to configData.templateSelectorOutput.

Studio validation and tooling

Layer / File(s) Summary
Async interaction test assertions
web/packages/studio/src/components/evaluation/Jobs/ActionMenu.test.tsx, web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/index.test.tsx, web/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/JobConfigDrawer.test.tsx
Tests now use waitFor for modal removal and close-callback assertions.
Workspace and tooling configuration
web/pnpm-workspace.yaml, web/package.json, web/.prettierignore, web/packages/studio/src/routes/WorkspaceDashboardRoute/ResourcesSection.tsx
Workspace dependency overrides and catalog versions changed, package-level overrides were removed, generated artifacts were added to Prettier exclusions, and the telemetry-enabled Report a Trace item gained href: '#'.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: upgrading Studio’s KUI dependency to 1.7.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/kui-1.7

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25557/32774 78.0% 62.6%
Integration Tests 14749/31423 46.9% 19.3%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@web/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsx`:
- Around line 98-103: Update the TextArea and TextInput instances in
LLMJudgeInput to receive the corresponding controller field handlers directly:
wire field.onChange and field.onBlur alongside each field’s current value.
Preserve the existing error status, placeholders, and input configuration while
ensuring all three controls can update and validate their FormField values.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aa423b5d-6dd5-48e2-81d7-bd963acae5e2

📥 Commits

Reviewing files that changed from the base of the PR and between a084a0a and f5e3cec.

📒 Files selected for processing (9)
  • web/packages/common/src/components/UploadModal/DatasetUploader/Select.tsx
  • web/packages/common/src/components/form/ControlledCheckbox/index.tsx
  • web/packages/common/src/components/form/ControlledCombobox/index.tsx
  • web/packages/common/src/components/form/ControlledRadioGroup/index.tsx
  • web/packages/studio/src/components/DatasetInputFile/index.tsx
  • web/packages/studio/src/components/evaluation/Configurations/form/InputFile/InputFileValidationBanner.tsx
  • web/packages/studio/src/components/evaluation/Configurations/form/LLMJudgeInput.tsx
  • web/packages/studio/src/components/evaluation/Configurations/form/MetricsCheckboxes.tsx
  • web/packages/studio/src/components/evaluation/Configurations/form/StringCheckInput.tsx

Signed-off-by: Sean Teramae <steramae@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant