Skip to content

fix(cli): harden formatting, pagination, and plugin loading#771

Draft
anastasia-nesterenko wants to merge 1 commit into
mainfrom
anesterenko/na-cli-fixes
Draft

fix(cli): harden formatting, pagination, and plugin loading#771
anastasia-nesterenko wants to merge 1 commit into
mainfrom
anesterenko/na-cli-fixes

Conversation

@anastasia-nesterenko

Copy link
Copy Markdown
Contributor

Summary

  • normalize multiline Markdown table cells with <br> and ensure valid separator widths
  • report accurate page numbers during page-number and cursor pagination
  • restore the root logging level after pagination, including when iteration fails
  • surface actionable errors when CLI plugins fail to load or build
  • refresh SDK generator and introspection tests against current jobs/workspaces APIs
  • mirror CLI fixes and tests into the vendored Python SDK

Testing

  • uv run --frozen pytest packages/nemo_platform_ext/tests/cli/core/test_formatters.py packages/nemo_platform_ext/tests/cli/core/test_pagination.py packages/nemo_platform_ext/tests/cli/test_app.py tools/nemo-platform-sdk-tools/tests/sdk/cli_generator/test_generator.py tools/nemo-platform-sdk-tools/tests/sdk/cli_generator/test_sdk_introspector.py -q
  • 232 passed

Signed-off-by: anastasia-nesterenko <anesterenko@nvidia.com>
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25560/32777 78.0% 62.6%
Integration Tests 14752/31426 46.9% 19.2%

@mckornfield mckornfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing crazy standing out to me

value = value.replace("|", "\\|")
# Keep each item on a single Markdown table row and escape cell
# delimiters. Normalize all newline forms before calculating widths.
value = value.replace("\r\n", "\n").replace("\r", "\n")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crlf, hate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants