Skip to content

fix(studio): Fix missing readme in fileset details causing large empty space#774

Open
steramae-nvidia wants to merge 2 commits into
mainfrom
steramae/fix-readme-fileset
Open

fix(studio): Fix missing readme in fileset details causing large empty space#774
steramae-nvidia wants to merge 2 commits into
mainfrom
steramae/fix-readme-fileset

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-07-17 at 2 53 01 PM Before Screenshot 2026-07-17 at 2 55 06 PM After

Signed-off-by: Sean Teramae steramae@nvidia.com

Summary by CodeRabbit

  • Bug Fixes
    • Improved fileset detail pages when no root README is available by showing metadata (and dataset sample information) without an empty content area.
    • Preserved the README-and-metadata layout for filesets that include documentation.
    • Streamlined README rendering to keep a consistent, cleaner page layout.

…y space

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners July 17, 2026 22:01
@steramae-nvidia

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

@github-actions github-actions Bot added the fix label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c205f6cf-f317-44be-881e-974739a195c4

📥 Commits

Reviewing files that changed from the base of the PR and between 2770b48 and 8bc3180.

📒 Files selected for processing (1)
  • web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx

📝 Walkthrough

Walkthrough

Changes

FilesetCard rendering

Layer / File(s) Summary
Conditional README and metadata layout
web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx
FilesetCard pre-builds metadata panels, renders them alone without a root README, and reuses them in the README grid when available.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change: it fixes missing README handling in fileset details to avoid excess empty space.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/fix-readme-fileset

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx`:
- Around line 73-87: Remove the early return guarded by hasReadme in the
FilesetCard component so ReadmeBody always mounts, including when readmePath is
falsy. Preserve the existing metaPanels layout and let ReadmeBody handle the
missing-README and files-load error fallback states.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ec511578-0c78-4236-9dca-f5a47c3ed25a

📥 Commits

Reviewing files that changed from the base of the PR and between 425bfdb and 2770b48.

📒 Files selected for processing (1)
  • web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx

Comment thread web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx Outdated
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25701/32944 78.0% 62.7%
Integration Tests 14784/31593 46.8% 19.2%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants