Clean up docs#806
Conversation
Remove device/index.rst and list the device pages directly in the root toctree under a new Devices caption, so they appear at the first level of the sidebar instead of nested under References. The device-plugin overview (and its device-interface-device-plugin anchor) moves to add_device.rst, and the lerobot devices page now links to the trackers and add_device pages directly. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
- Drop the Module Index link from the root page: no Python modules are documented, so Sphinx never generates py-modindex.html. - Fix the DeviceIOSession source link to the current src/core/deviceio_session/ path. - Remove the reference to cmake/SetupHunter.cmake, which does not exist; the documented options live in CMakeLists.txt and SetupPython.cmake. - Collapse whitespace in the code-file/code-dir role parser so line-wrapped 'label <path>' targets parse correctly (fixes a mangled replay.yaml link on the camera streaming page). - Render the viser localhost URL as an inline literal instead of an auto-generated hyperlink. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
📝 WalkthroughWalkthroughThe changes normalize whitespace when parsing code roles, add device-plugin retargeting guidance, reorganize device and reference documentation navigation, update a CMake file reference, correct the documented Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/device/add_device.rst`:
- Line 1: Add the repository-standard REUSE SPDX copyright and license header at
the beginning of the documentation file, before the
device-interface-device-plugin Sphinx label. Preserve the existing label and all
following content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c2a08e67-af39-45ca-89af-b2185475e5a5
📒 Files selected for processing (8)
docs/source/conf.pydocs/source/device/add_device.rstdocs/source/device/index.rstdocs/source/getting_started/build_from_source/index.rstdocs/source/getting_started/lerobot/devices.rstdocs/source/getting_started/teleop_session.rstdocs/source/index.rstdocs/source/references/mcap_record_replay.rst
💤 Files with no reviewable changes (1)
- docs/source/device/index.rst
| @@ -1,6 +1,15 @@ | |||
| .. _device-interface-device-plugin: | |||
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Add the required REUSE SPDX header.
This file starts at Line 1 with a Sphinx label but has no standard SPDX copyright/license block, unlike the other changed documentation files. Add the repository-standard header before the label.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/source/device/add_device.rst` at line 1, Add the repository-standard
REUSE SPDX copyright and license header at the beginning of the documentation
file, before the device-interface-device-plugin Sphinx label. Preserve the
existing label and all following content unchanged.
Source: Coding guidelines
Description
Fixes #(issue)
Type of change
Testing
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCOSummary by CodeRabbit