Integrate Automated QDQ placement tool - part 2.3#846
Integrate Automated QDQ placement tool - part 2.3#846willg-nv wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
📝 WalkthroughWalkthroughIntroduces a new module that provides region search inspection capabilities for ONNX models. The tool loads models, converts them to GraphSurgeon graphs, executes a two-phase region search, collects and filters regions, generates statistics, and exposes both programmatic and CLI interfaces. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@modelopt/onnx/quantization/autotune/region_inspect.py`:
- Around line 189-196: The log message is misleading because
inspect_region_search returns all regions but the logger.info says "top-level
regions"; update the logger.info call that logs len(regions) (the variable
assigned from inspect_region_search) to accurately describe the content (e.g.,
"regions discovered" or "all regions discovered") so the message reflects that
inspect_region_search returns all_regions rather than only top-level regions.
- Around line 47-57: Update the docstring in region_inspect.py so the API name
matches the implementation: replace references to search() with search_regions()
(and any nearby mention of "Two-Phase Search: Runs automatically via
CombinedRegionSearch.search()" to "CombinedRegionSearch.search_regions()") and
scan the surrounding text for any other mismatched mentions of search() to
ensure all documentation refers to the actual method
CombinedRegionSearch.search_regions().
68d3339 to
a03ea73
Compare
Signed-off-by: Will Guo <willg@nvidia.com>
a03ea73 to
610d9a9
Compare
|
@willg-nv can we add a unittest for this file? Thanks. |
Signed-off-by: Will Guo <willg@nvidia.com>
Yes, please check the latest commit. |
What does this PR do?
This PR implement RegionInspect tool. This tool could be used to visualize the regions parititioned by RegionSearch classes. This tool could be used to analyze if the partitioned regions match the fusion patterns.
Overview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
New Features