Add option to enable eager authentication#1837
Draft
thepatrickchin wants to merge 19 commits intoNVIDIA:developfrom
Draft
Add option to enable eager authentication#1837thepatrickchin wants to merge 19 commits intoNVIDIA:developfrom
thepatrickchin wants to merge 19 commits intoNVIDIA:developfrom
Conversation
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
- "same-page" may be misleading as the popup is what keeps the user on the same page. Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
- Fail fast when redirect auth has no validated return URL. - Handle redirect-mode failures the same way as redirect-mode success. - Properly handle wildcard "*" in allow_origins Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
- Only treat access_denied as a user cancellation. Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
- Gate cancellation UX with use_redirect_auth, not return_url. - Add a popup-mode regression test when return_url is present. Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
- This makes pre-authentication an opt-in feature - When True, authentication for the provider is triggered at WebSocket connection time before any user message is submitted. - When False (default), authentication only occurs when the workflow explicitly requires it. Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
f03df62 to
61671c5
Compare
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
4eee604 to
b768527
Compare
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
use_eager_authoption in auth provider configurations to trigger authentication flow at WebSocket connection time. This is an opt-in feature that preserves the existing behavior of triggering auth flow when the workflow requires credentials whenuse_eager_authis false (default).If the user cancels or declines the initial authentication request, the authorization flow will still be triggered when the workflow requires credentials.
Closes #1836
By Submitting this PR I confirm: