fix(install): improve Windows dependency setup and build profiles - #15
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (12)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. 📝 WalkthroughWalkthroughWindows builds now use profiles, automatic pinned vcpkg provisioning, explicit backend configuration, and stronger validation. The installer forwards these options to source builds, validates installed binaries, and documents the new workflow. ChangesWindows build and installation flow
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The affected runtime parameter initialization remains safely default-initialized, so the Windows installation and build changes present no identified merge-blocking risk and are merge-ready after normal checks. Sequence Diagram(s)sequenceDiagram
participant Installer
participant WindowsBuild
participant Vcpkg
participant CMake
participant InstalledBinary
Installer->>WindowsBuild: Pass profile, components, CUDA, and vcpkg options
WindowsBuild->>Vcpkg: Bootstrap and install manifest features
WindowsBuild->>CMake: Configure selected components and backend
CMake-->>WindowsBuild: Build and install binaries
WindowsBuild-->>Installer: Complete source installation
Installer->>InstalledBinary: Run --version and --json doctor
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Fixes #12
Summary by CodeRabbit
New Features
Bug Fixes
Documentation