Skip to content

fix(install): improve Windows dependency setup and build profiles - #15

Merged
pskrunner14 merged 1 commit into
mainfrom
windows-install
Aug 18, 2026
Merged

fix(install): improve Windows dependency setup and build profiles#15
pskrunner14 merged 1 commit into
mainfrom
windows-install

Conversation

@pskrunner14

@pskrunner14 pskrunner14 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Fixes #12

Summary by CodeRabbit

  • New Features

    • Added Windows installation profiles for core, ASR, server, full, and developer setups.
    • Added optional controls for CUDA, HTTP TLS, gRPC, Flashlight, translation, and Japanese/Chinese text-to-speech components.
    • Windows builds can now automatically provision required C++ dependencies.
    • Installed server builds now include the server runtime executable.
  • Bug Fixes

    • Improved backend and GPU detection, configuration validation, and post-installation health checks.
    • Added Visual C++ runtime installation support for Windows.
  • Documentation

    • Updated Windows installation and build guidance, including CUDA, Vulkan, dependency, and profile configuration.

@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 2f22f206-5fa3-43dd-90d1-0e6cf086463f

📥 Commits

Reviewing files that changed from the base of the PR and between 9bc8766 and fc23931.

📒 Files selected for processing (12)
  • CMakeLists.txt
  • THIRD_PARTY_NOTICES.md
  • docs/development/windows-build.md
  • docs/install.md
  • scripts/install.ps1
  • scripts/windows/build.ps1
  • src/server/CMakeLists.txt
  • tests/cpp/asr/test_diar_streaming.cpp
  • tests/cpp/asr/test_rnnt_concurrency.cpp
  • tests/cpp/asr/test_sortformer_parity.cpp
  • tests/install/install_ps1_test.py
  • vcpkg.json

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Windows builds now use profiles, automatic pinned vcpkg provisioning, explicit backend configuration, and stronger validation. The installer forwards these options to source builds, validates installed binaries, and documents the new workflow.

Changes

Windows build and installation flow

Layer / File(s) Summary
Dependency manifest and packaging contracts
vcpkg.json, CMakeLists.txt, src/server/CMakeLists.txt, THIRD_PARTY_NOTICES.md
CMake validates incompatible options, installs Visual C++ runtime and dependency license files, installs riva_server, and uses the new vcpkg feature manifest.
Profile-driven Windows build
scripts/windows/build.ps1, docs/development/windows-build.md, tests/cpp/asr/*
The build script derives components from profiles, provisions vcpkg and submodules, validates CUDA and Vulkan tools, configures explicit backends, and updates related build documentation and test initialization.
Installer profiles and source validation
scripts/install.ps1, tests/install/install_ps1_test.py, docs/install.md
The installer accepts profile and dependency options, selects binary or source installation, forwards build settings, records installation identity, and validates installed binaries with --version and --json doctor.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to fc239

The affected runtime parameter initialization remains safely default-initialized, so the Windows installation and build changes present no identified merge-blocking risk and are merge-ready after normal checks.

Sequence Diagram(s)

sequenceDiagram
  participant Installer
  participant WindowsBuild
  participant Vcpkg
  participant CMake
  participant InstalledBinary
  Installer->>WindowsBuild: Pass profile, components, CUDA, and vcpkg options
  WindowsBuild->>Vcpkg: Bootstrap and install manifest features
  WindowsBuild->>CMake: Configure selected components and backend
  CMake-->>WindowsBuild: Build and install binaries
  WindowsBuild-->>Installer: Complete source installation
  Installer->>InstalledBinary: Run --version and --json doctor
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the Windows dependency setup and build profile changes.
Linked Issues check ✅ Passed The installer and Windows build changes provision vcpkg dependencies for source builds, including SentencePiece, while preserving source setup workflows [#12].
Out of Scope Changes check ✅ Passed The changes support Windows installation, dependency provisioning, build profiles, documentation, packaging, and related build compatibility.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch windows-install

Comment @coderabbitai help to get the list of available commands.

@anand-nv anand-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pskrunner14
pskrunner14 merged commit 4c749a7 into main Aug 18, 2026
3 checks passed
@pskrunner14
pskrunner14 deleted the windows-install branch August 18, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.ps1 skips vcpkg dependency build → CMake fails to find sentencepiece.lib

2 participants