ci: install cargo-zigbuild from release binaries#1533
Merged
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-1533.docs.buildwithfern.com/openshell |
TaylorMutch
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch
cargo-zigbuildfrom mise's Cargo installer backend to the upstream GitHub release binary backend. This avoids compilingcargo-zigbuildwhile building the CI image.Related Issue
Follow-up to #1490. Addresses the CI image build failure seen in https://github.com/NVIDIA/OpenShell/actions/runs/26307047083/job/77447174837.
Changes
cargo:cargo-zigbuildwithgithub:rust-cross/cargo-zigbuildinmise.toml.mise.lockwith prebuiltcargo-zigbuildassets for linux-x64, linux-arm64, and macos-arm64.cargo-zigbuildversion,0.22.3.This approach is better for the CI image because
mise install --lockedcan download and verify upstream release binaries instead of compilingcargo-zigbuildat image-build time. Building it from source requires the Rust toolchain andRUSTC_WRAPPER/sccache configuration to already be correct during tool installation, which is exactly what failed in the CI image build.Testing
mise run pre-commitpassesgit diff --checkpassesmise install --locked github:rust-cross/cargo-zigbuild@0.22.3downloads the prebuilt binarymise x -- cargo zigbuild --helpruns successfullyChecklist