Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4329.docs.buildwithfern.com/openshell |
9 of 10 tasks
elezar
force-pushed
the
codex/podman-cdi-discovery/elezar
branch
from
October 8, 2026 11:40
95e8bcb to
2870595
Compare
elezar
changed the base branch from
main
to
fix/2-podman-device-validation/alangou
October 8, 2026 11:40
Base automatically changed from
fix/2-podman-device-validation/alangou
to
main
October 8, 2026 12:39
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
codex/podman-cdi-discovery/elezar
branch
from
October 9, 2026 09:43
2870595 to
c521ef0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default GPU requests currently infer Podman CDI devices from the gateway host's
/dev, which can differ from the Podman server's CDI inventory. Read server info at initialization and before default GPU validation and creation, preserving legacy discovery only when the server omits both CDI fields.Related Issue
Follow-up to merged PR #4306. This PR now targets
main.No issue linked yet. This draft is being opened at the maintainer's explicit request; add a scope-matched issue before marking it ready for review.
Changes
host.cdiSpecDirsand source-qualifiedhost.discoveredDevicesfrom the existing/v5.0.0/libpod/infoendpoint.Testing
main: 242 tests passed.mise run pre-commitpassed during initial implementation (sccache disabled via a temporary local override).A live Fedora tmachine API check on Podman 5.8.1 confirmed the legacy response omits both CDI fields. New-server response shapes came from earlier synthetic-spec verification on Podman 6.1.1; mocked tests exercise those shapes against this implementation. No real GPU execution was tested. An earlier
mise run ciattempt stopped at the unrelated prover link step because this host lackslibz3. CDI syntax validation is already onmainthrough merged PR #4306; this PR's diff contains only discovery, tests, and documentation. Unrelated testing-strategy commits are excluded.Checklist