[Pytorch] Skip the Single Grouped Param Test if NVTE_GROUPED_LINEAR_SINGLE_PARAM=0#3061
Conversation
… weight Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
|
/te-ci pytorch |
for more information, see https://pre-commit.ci
Greptile SummaryAdds a
Confidence Score: 5/5The change is a narrow, well-scoped skip guard in a test file; it cannot affect production code and matches the established pattern already used in the test suite. The guard correctly defaults to '0' when the env var is absent, so both the unset case and the explicitly-disabled case are handled the same way as utils.py and test_fusible_ops.py. No production code is touched, and CI already sets the flag so the single-param tests still run in the full suite. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["test_sanity_grouped_linear(single_param=True/False)"] --> B{"NVTE_GROUPED_LINEAR_SINGLE_PARAM == '0'\nAND single_param == True?"}
B -- Yes --> C["pytest.skip()\n'requires NVTE_GROUPED_LINEAR_SINGLE_PARAM=1'"]
B -- No --> D["Continue test setup"]
D --> E["GroupedLinear(\n single_grouped_weight=single_param,\n single_grouped_bias=single_param\n)"]
E --> F{"single_param == True?"}
F -- Yes --> G["check_grouped_weight()\ncheck_grouped_bias()"]
F -- No --> H["Run inference + backward"]
G --> H
Reviews (2): Last reviewed commit: "Apply suggestion from @greptile-apps[bot..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: vthumbe1503 <vthumbe@nvidia.com>
|
B200 is the only pending test in CI. And they are passing when manually tested. Merging the PR |
…INGLE_PARAM=0 (#3061) * skip the test if the env variable is not turned on for single grouped weight Signed-off-by: Varun Thumbe <vthumbe@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestion from @greptile-apps[bot] Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: vthumbe1503 <vthumbe@nvidia.com> --------- Signed-off-by: Varun Thumbe <vthumbe@nvidia.com> Signed-off-by: vthumbe1503 <vthumbe@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: