Misc docs rendering fixes - #3450
Merged
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
# Conflicts: # .github/workflows/docs.yml
ksivaman
marked this pull request as draft
August 31, 2026 22:40
Contributor
Greptile SummaryThe PR improves documentation rendering across light and dark themes.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Dark mode fixes for docs diagrams, tabs ..." | Re-trigger Greptile |
- diagram-colors.css: dark variants for all remaining diagram box/text classes; accent color classes replacing hardcoded inline fills - sphinx-tabs: dark styling for tabs and panels - output blocks: class-based "Output:" / "Needs to be run on" headers attached to code blocks, dark variants; fix light background forced by pydata on rendered_html notebook outputs - <img>-embedded SVGs: invert filter in dark mode; removed full-canvas white background rects so diagrams blend with the page - inline SVGs: moved hardcoded dark inline fills to themable classes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
pggPL
marked this pull request as ready for review
September 1, 2026 09:45
Collaborator
|
@ksivaman I fixed style issues and I think it looks OK |
ptrendx
approved these changes
Sep 1, 2026
ptrendx
approved these changes
Sep 1, 2026
ptrendx
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: