Attribute and retry transient CP pool NaNs - #3453
Open
sudhakarsingh27 wants to merge 1 commit into
Open
Conversation
Retained FP8 THD pool workers can report transient NaN assertions that clear in a fresh worker. Keep retry matching constrained to documented signatures and one fresh-worker attempt. Include the active pytest node and terminal retry outcome so recovered attempts can be distinguished from final failures in CI logs. Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
Contributor
Greptile SummaryThis PR extends the context-parallel attention test pool’s narrowly scoped retry policy to recognize two FP8 THD NaN signatures and makes retry outcomes attributable in CI logs.
Confidence Score: 5/5The PR appears safe to merge because matching failures are retried in a newly spawned pool and a repeated failure is still propagated. The retry gate is limited to the intended FP8 THD cases and documented signatures, successful retries are explicitly recorded, and all terminal second-attempt errors remain test failures. Important Files Changed
Reviews (1): Last reviewed commit: "Attribute and retry transient CP pool Na..." | Re-trigger Greptile |
Member
Author
|
/te-ci pytorch L1 |
Collaborator
|
/te-ci pytorch L1 |
2 similar comments
Member
Author
|
/te-ci pytorch L1 |
Collaborator
|
/te-ci pytorch L1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Long-lived context-parallel workers can occasionally retain state across heterogeneous FP8 THD cases. A fresh pool can clear these transient assertion failures, while a failure repeated in the fresh pool must remain visible.
This change also makes the retry lifecycle explicit so recovered attempts are distinguishable from terminal test failures.
Type of change
Changes
Validation
main, the retry control-flow harness covered transient recovery, persistent failure, the existing NaN signature, unrelated NaN rejection, and non-THD rejection.Checklist