[Common] Group NVFP4 Quantize Kernels - #3458
Open
Oleg-Goncharov wants to merge 6 commits into
Open
Conversation
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Contributor
Greptile SummaryThis PR adds coordinated grouped NVFP4 1D quantization and transpose kernels, integrates them with grouped dispatch and layout infrastructure, and adds extensive native test coverage.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported grouped scaling-mode dispatch branches are active at the current head. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
I[Grouped BF16 input] --> D[Grouped quantization dispatch]
D --> K[Grouped NVFP4 quantize and transpose kernel]
K --> R[Rowwise packed FP4 data and scales]
K --> C[Columnwise packed FP4 data and scales]
R --> G[Grouped GEMM consumers]
C --> G
Reviews (3): Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." | Re-trigger Greptile |
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Oleg-Goncharov
force-pushed
the
pr_nvfp4_group_kernels
branch
from
September 1, 2026 20:48
71dd22f to
2fdd9c3
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: