Skip to content

Bind Brev services to all interfaces#208

Open
robobryce wants to merge 1 commit into
NVIDIA:mainfrom
robobryce:fix/brev-compose-bindings
Open

Bind Brev services to all interfaces#208
robobryce wants to merge 1 commit into
NVIDIA:mainfrom
robobryce:fix/brev-compose-bindings

Conversation

@robobryce

@robobryce robobryce commented Jul 10, 2026

Copy link
Copy Markdown

Summary

  • bind JupyterLab and Nsight HTTP ports to 0.0.0.0 in every ACH Brev Docker Compose file
  • update the remaining TURN binding in the floating-point emulation tutorial
  • support the updated Brev backend networking requirements

Validation

  • docker compose -f <file> config --quiet for all seven Brev Compose files
  • confirmed no 127.0.0.1 bindings remain in the Brev Compose files
  • git diff --check

@copy-pr-bot

copy-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your contribution!

This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI.

@maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI.

@robobryce robobryce force-pushed the fix/brev-compose-bindings branch from 25fa0d0 to 522cf22 Compare July 10, 2026 19:16
@brycelelbach

Copy link
Copy Markdown
Collaborator

/ok to test 522cf22

@robobryce

Copy link
Copy Markdown
Author

The floating-point-emulation image built and pushed successfully, but its Trigger test workflow step hit a transient GitHub API error:

HTTP 500: Failed to run workflow dispatch

The other six matrix jobs dispatched normally. Could a maintainer please rerun the failed job in build run 29117706953?

@robobryce robobryce force-pushed the fix/brev-compose-bindings branch from 522cf22 to 84630c9 Compare July 10, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants