Clean up Jupyter Nsight integration#210
Open
robobryce wants to merge 1 commit into
Open
Conversation
Contributor
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
Author
|
Upstream CI is ready for maintainer approval on signed head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jupyterlab-nvidia-nsightextension from every tutorial image*.brevlab.com/TURN settings and deadBREV_ENV_IDCompose plumbingnsysandncuCompose services after a clean Jupyter shutdownRationale
The Nsight Systems and Nsight Compute launcher entries are provided by
jupyter-server-proxy, notjupyterlab-nvidia-nsight. This was confirmed on a live Brev node through/server-proxy/servers-info; both/nsys/and/ncu/returned HTTP 200 independently of the legacy extension UI.The restart path stays in the root Jupyter wrapper, which already has the Docker socket. Jupyter remains unprivileged. A small standard-library helper identifies sibling containers using Docker Compose labels and restarts only
nsysandncuafter Jupyter exits cleanly.Related: #209 restores the
socatforwarders used by the named proxies.Validation
nsysandncusiblingsdocker compose config --quietfor every Brev Compose filebash -n,shellcheck, and Python compilation