Add sm107 tunings for DevicePartition::Flagged - #11197
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
DevicePartition::Flagged0e515f9 to
143fef2
Compare
📝 SummarySummary by CodeRabbit
WalkthroughChangesThe SM107 dispatch path now supports benchmark-selected tuning for flagged partition operations with 4-byte offsets. Supported inputs include primitive and 128-bit types of 1, 4, 8, and 16 bytes. Two-byte inputs remain untuned. SM107 flagged partition tuning
Suggested reviewers: Merge Risk: 🔵 Low · up to This change adds SM107-specific flagged-partition tuning selection for supported inputs. The remaining risk is limited to aligning the new helper's exception specification with adjacent code before merge. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 972a6288-5d7c-4cc7-8a17-7b8fcdabf96d
📒 Files selected for processing (1)
cub/cub/device/dispatch/tuning/tuning_select_if.cuh
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.
|
|
||
| // tunings from cub/benchmarks/bench/partition/flagged.cu, which benchmarks with 4-byte offsets. These are raw | ||
| // measured values and must not be passed through nominal_4B_items_to_items. | ||
| [[nodiscard]] _CCCL_HOST_DEVICE_API constexpr auto get_sm107_flagged_partition_tuning() const |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
important: Add noexcept to get_sm107_flagged_partition_tuning. The function only reads fields and constructs value types. The adjacent get_sm107_partition_tuning has this contract. As per coding guidelines, “Functions that do not throw exceptions must be marked noexcept.”
Source: Coding guidelines
🔬 CUB benchmark SASS comparisonHow to request a benchmark run
Targets with a SASS change
|
🥳 CI Workflow Results🟩 Finished in 2h 46m: Pass: 100%/176 | Total: 8d 11h | Max: 2h 46m | Hits: 28%/638149See results here. |
closes https://github.com/NVIDIA-dev/cccl_private/issues/721?issue=NVIDIA-dev%7Ccccl_private%7C831
perf verification results