[DRAFT] Optimize offset based DeviceSegmentedReduce for small and medium segment sizes#6942
Closed
srinivasyadav18 wants to merge 12 commits into
Closed
[DRAFT] Optimize offset based DeviceSegmentedReduce for small and medium segment sizes#6942srinivasyadav18 wants to merge 12 commits into
srinivasyadav18 wants to merge 12 commits into
Conversation
…size::max_segment_size`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…segment_size::max_segment_size`" This reverts commit 5bf0477.
This comment has been minimized.
This comment has been minimized.
Contributor
😬 CI Workflow Results🟥 Finished in 6h 00m: Pass: 75%/95 | Total: 4d 16h | Max: 6h 00m | Hits: 73%/95813See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #6898
Checklist
cuda::execution::guaranteeandcuda::execution::segment_size::max_segment_size#6682Status
The current version of PR show's good speed ups for I32/F32 (reaching upto 70%) with
Sum, but only very decent improvements (upto 10% SOL from < 1% SOL) with more complex operator's likeArgMaxor larger input types (> 4B).Some intial benchmarks:
Sum T{ct}=F32
ArgMax T{ct}=F64