Skip to content

Rename block_scan_algorithm to scan_algorithm#9244

Open
bernhardmgruber wants to merge 1 commit into
NVIDIA:mainfrom
bernhardmgruber:rename_block_scan_alg
Open

Rename block_scan_algorithm to scan_algorithm#9244
bernhardmgruber wants to merge 1 commit into
NVIDIA:mainfrom
bernhardmgruber:rename_block_scan_alg

Conversation

@bernhardmgruber
Copy link
Copy Markdown
Contributor

This member of three_way_partition_policy was the only tuning policy member of for a BlockScanAlgorithm that was not spelled scan_algorithm. Renaming for consistency. See also: https://docs.google.com/spreadsheets/d/1EUdwvmv2n7-WRp30-lt7CQxyu8r6atdfJJx3O6Pf1Ag

@bernhardmgruber bernhardmgruber requested a review from a team as a code owner June 3, 2026 21:48
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 3, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9192c872-31cd-4fe3-9aa9-e0e8b11f49ba

📥 Commits

Reviewing files that changed from the base of the PR and between 4de514e and 90c3bac.

📒 Files selected for processing (2)
  • cub/cub/device/dispatch/kernels/kernel_three_way_partition.cuh
  • cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh
🚧 Files skipped from review as they are similar to previous changes (1)
  • cub/cub/device/dispatch/kernels/kernel_three_way_partition.cuh

Note: CodeRabbit is enabled on this repository as a convenience for maintainers
and contributors. Use your best judgment when considering its review comments and
suggestions — a suggested change may be inadequate, unnecessary, or safe to ignore.
Contributors are not expected to address every comment. Human reviews are what
ultimately matter for merging.

Summary

This PR renames the block_scan_algorithm member to scan_algorithm in the three_way_partition_policy struct for consistency with other tuning policy naming conventions. The rename is tracked in the referenced tuning-policy spreadsheet.

Changes

cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh

  • Renamed member block_scan_algorithmscan_algorithm (type: BlockScanAlgorithm) in three_way_partition_policy.
  • Updated equality operator to compare lhs.scan_algorithm == rhs.scan_algorithm.
  • Updated stream output to print .scan_algorithm = and to access policy.scan_algorithm.

cub/cub/device/dispatch/kernels/kernel_three_way_partition.cuh

  • Updated AgentThreeWayPartitionPolicyT instantiation to use active_policy.scan_algorithm (replaced prior use of active_policy.block_scan_algorithm).

Impact

  • Localized rename and call-site update; other files already follow scan_algorithm naming.
  • No exported/public API signature changes beyond the member rename in the tuning policy type.
  • Lines changed are minimal (+1 / -1 in kernel; +3 / -3 in tuning header). Estimated review effort: Medium.

Walkthrough

suggestion: Rename three_way_partition_policy::block_scan_algorithm to scan_algorithm; update kernel instantiation and host formatter to use scan_algorithm. All observable call sites in these changes now reference the new member name.

Changes

Three-way partition policy rename

Layer / File(s) Summary
Policy member rename and host formatter
cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh
Replace block_scan_algorithm with scan_algorithm in three_way_partition_policy. Update equality comparison and host operator<< to reference scan_algorithm and print policy.scan_algorithm.
Kernel consumer update
cub/cub/device/dispatch/kernels/kernel_three_way_partition.cuh
DeviceThreeWayPartitionKernel now passes active_policy.scan_algorithm to AgentThreeWayPartitionPolicyT as the scan algorithm template argument.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f6c3eb99-b4a0-4e8c-b49a-fd07dbeac8b9

📥 Commits

Reviewing files that changed from the base of the PR and between b336700 and 4de514e.

📒 Files selected for processing (2)
  • cub/cub/device/dispatch/kernels/kernel_three_way_partition.cuh
  • cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh

Comment thread cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh
Comment thread cub/cub/device/dispatch/tuning/tuning_three_way_partition.cuh
This member of three_way_partition_policy was the only tuning policy
member of for a BlockScanAlgorithm that was not spelled scan_algorithm.
Renaming for consistency.
@bernhardmgruber bernhardmgruber force-pushed the rename_block_scan_alg branch from 4de514e to 90c3bac Compare June 3, 2026 21:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🥳 CI Workflow Results

🟩 Finished in 2h 15m: Pass: 100%/284 | Total: 11d 02h | Max: 2h 14m | Hits: 21%/904815

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant