Repository navigation
docs: Describe device list settings when CDI is enabled - #525
Open
mikemckiernan wants to merge 1 commit into
Open
mikemckiernan wants to merge 1 commit into
mikemckiernan wants to merge 1 commit into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Documentation preview |
mikemckiernan
marked this pull request as ready for review
October 16, 2026 13:48
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
mikemckiernan
force-pushed
the
devin/1792157898-cdi-device-list-strategy
branch
from
October 16, 2026 16:54
3d7d4b5 to
c3ccdbb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review HTML: https://nvidia.github.io/cloud-native-docs/review/pr-525/gpu-operator/latest/cdi.html
Summary
Adds a "CDI and Device List Settings" subsection to
gpu-operator/cdi.rst, and a cross-reference to it from "Enabling CDI". The subsection tells administrators that, when CDI is enabled:DEVICE_LIST_STRATEGY. The Operator setscdi-cri,cdi-annotationson the device plugin, andcdi-annotationsis the fallback when CRI CDI support is missing.devicePlugin.envDEVICE_LIST_STRATEGYthemselves, that value replaces the Operator's value. The value must contain onlycdi-cri,cdi-annotations, sovolume-mountsandenvvarmust be removed.toolkit.envACCEPT_NVIDIA_VISIBLE_DEVICES_AS_VOLUME_MOUNTS.The section names the symptom (
unresolvable CDI devices management.nvidia.com/gpu=GPU-<uuid>) and includes a valid YAML example.Basis:
transformDevicePluginCtrForCDIin gpu-operatorcontrollers/object_controls.go, and the repro in NVIDIA/gpu-operator#3077. Related: NVIDIA/gpu-operator#3081 (guardrail, open).The local
gpu-operatorbuild produced no new warnings; the existing tab-set errors indra-intro-install.rstandgpu-driver-upgrades.rstare unrelated. The pre-commit hooks could not be fetched in the authoring environment; I checked trailing whitespace by hand.Questions for reviewers
volume-mountsfail even whenACCEPT_NVIDIA_VISIBLE_DEVICES_AS_VOLUME_MOUNTSis unset?runtimeClassName: nvidiafail the same way?management.nvidia.com/gpukind is fixed for workload pods (gpu-operator#3077), does this guidance change?cdi-criandcdi-annotationsat run time? The fallback sentence depends on the answer.Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/9c26f672c2354d3e88fe31b5eb47c065
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/9c26f672c2354d3e88fe31b5eb47c065?variant=devin
Requested by: @mikemckiernan