Skip to content

Fix Dragon inference with local loader processes - #91

Merged
tpn merged 1 commit into
mainfrom
codex/dragon-loader-bootstrap-20261001
Oct 1, 2026
Merged

tpn merged 1 commit into
mainfrom
codex/dragon-loader-bootstrap-20261001

Conversation

@tpn

@tpn tpn commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Dragon xScan inference with --num-workers 1 stalls before READY because the local Python spawn child receives a Dragon-patched queue and cannot finish bootstrap. Keep Python multiprocessing unpatched when starting native Dragon workers, so their local DataLoader children use ordinary spawn queues while native Dragon coordination remains intact.

Validated on x86-64 B200 and two-node aarch64 GB200 with two GPU workers and three repeated rounds. Positive-loader inference and the default loader path complete; scientific outputs match the original candidate's working loader-zero baseline exactly, loader children persist across rounds, and shutdown leaves no owned processes. Separate fix wheels preserve the original candidate evidence. All 35 focused lifecycle tests, including a real Dragon spawn-queue regression, and pre-commit checks pass.

@tpn
tpn requested a review from melo-gonzo as a code owner October 1, 2026 06:43
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 68811c6b-a997-4c92-a0f6-8f9e803c4de3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@melo-gonzo melo-gonzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All 35 lifecycle tests passed with Dragon 0.14.2, and the new spawn-queue regression fails on the base revision. The environment overlay preserves inherited variables and leaves the coordinator environment unchanged. Multi-node B200/GB200 validation was not independently repeated.

@tpn
tpn changed the base branch from 0.1.x to main October 1, 2026 15:55
Signed-off-by: Trent Nelson <trentn@nvidia.com>
@tpn
tpn force-pushed the codex/dragon-loader-bootstrap-20261001 branch from 0611603 to 4047d64 Compare October 1, 2026 15:56
@tpn
tpn merged commit b713503 into main Oct 1, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants