Conversation
Filter normal-equation rows only when a fallback was needed. Skip the second residual-budget filter for analytic derivatives; keep it for finite differences, with a boundary regression test. Signed-off-by: Trent Nelson <trentn@nvidia.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The normal-equation path copied five arrays even when every row was valid,
and filtered trial-evaluation budgets after analytic Jacobians that consume no
residual evaluations. Skip those operations to reduce repeated host work in
xFit's shared solver. Preserve fallback filtering and finite-difference budget
checks, with a regression for exhausting the budget just before a trial in both
implicit and explicitly requested finite-difference modes.
Validation
make ci-lint— passed, including mypy, Ruff, pre-commit and lock validation.make package-check— source distribution built; strict package checks passed.pytest -q tests/xfit/test_solver.py tests/xfit/test_numba_mlir.py tests/xfit/test_numba_mlir_commands.py— 67 passed, no skips, with CUDA 13 and free-threaded Python.With free-threaded Python 3.14 and Numba-CUDA-MLIR 0.5.4, one concurrent
warmup attempt failed in dependency type dispatch. Performance validation
covers successful warmed fits; the effect of this change on concurrent-startup
reliability remains undetermined.
Repository hygiene