Skip to content

Accept post-release wheel versions in release validation#2178

Merged
lijinf2 merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix-post-release-wheel-validation
Jul 7, 2026
Merged

Accept post-release wheel versions in release validation#2178
lijinf2 merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix-post-release-wheel-validation

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reuse the release-note tag parser in validate-release-wheels
  • preserve .postN versions from release tags instead of truncating to X.Y.Z
  • keep release wheel tag parsing aligned with the existing release-note tag rules

Why

Post-release tags such as v12.6.2.post1 were parsed as 12.6.2, so valid wheels like cuda_bindings-12.6.2.post1-...whl failed release validation before upload or publishing.

Testing

  • uvx ruff check ci/tools/validate-release-wheels
  • uvx ruff format --check ci/tools/validate-release-wheels
  • direct smoke test: ./ci/tools/validate-release-wheels v12.6.2.post1 cuda-bindings <tmp-wheel-dir>
  • direct negative smoke test: ./ci/tools/validate-release-wheels v12.6.2 cuda-bindings <tmp-wheel-dir> rejects a 12.6.2.post1 wheel

@copy-pr-bot

copy-pr-bot Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Jun 7, 2026
Comment thread ci/tools/tests/test_validate_release_wheels.py Outdated
@leofang leofang added enhancement Any code-related improvements P2 Low priority - Nice to have labels Jun 8, 2026
@leofang leofang added this to the cuda.core v1.1.0 milestone Jun 8, 2026
@fallintoplace fallintoplace force-pushed the fix-post-release-wheel-validation branch from d6e645d to 14302e5 Compare June 8, 2026 18:51

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits before merge: the argv plumbing on main/parse_args is unused without tests and can be reverted, and the ValueError message should mention the new .postN support so it stops contradicting the behavior. Otherwise the rewrite looks good — also closes a latent unanchored-regex bug where v12.6.2.dev1 would silently validate a 12.6.2 wheel.

Comment thread ci/tools/validate-release-wheels Outdated
Comment thread ci/tools/validate-release-wheels Outdated
@fallintoplace fallintoplace force-pushed the fix-post-release-wheel-validation branch from 14302e5 to 832ffd0 Compare June 10, 2026 20:07
@Andy-Jost Andy-Jost mentioned this pull request Jul 6, 2026
14 tasks
@leofang leofang requested a review from lijinf2 July 7, 2026 18:11
@Andy-Jost

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@Andy-Jost, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@lijinf2

lijinf2 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test 0615816

@github-actions

This comment has been minimized.

@lijinf2 lijinf2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. This fixes git tag matching for both regular releases and .postN post-releases. I see all comments have been addressed. Looks good to me.

@lijinf2 lijinf2 merged commit 35144d0 into NVIDIA:main Jul 7, 2026
104 checks passed
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure enhancement Any code-related improvements P2 Low priority - Nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants