Accept post-release wheel versions in release validation#2178
Conversation
d6e645d to
14302e5
Compare
leofang
left a comment
There was a problem hiding this comment.
Two nits before merge: the argv plumbing on main/parse_args is unused without tests and can be reverted, and the ValueError message should mention the new .postN support so it stops contradicting the behavior. Otherwise the rewrite looks good — also closes a latent unanchored-regex bug where v12.6.2.dev1 would silently validate a 12.6.2 wheel.
14302e5 to
832ffd0
Compare
|
/ok to test |
@Andy-Jost, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test 0615816 |
This comment has been minimized.
This comment has been minimized.
lijinf2
left a comment
There was a problem hiding this comment.
Thank you for the PR. This fixes git tag matching for both regular releases and .postN post-releases. I see all comments have been addressed. Looks good to me.
|
Summary
validate-release-wheels.postNversions from release tags instead of truncating toX.Y.ZWhy
Post-release tags such as
v12.6.2.post1were parsed as12.6.2, so valid wheels likecuda_bindings-12.6.2.post1-...whlfailed release validation before upload or publishing.Testing
uvx ruff check ci/tools/validate-release-wheelsuvx ruff format --check ci/tools/validate-release-wheels./ci/tools/validate-release-wheels v12.6.2.post1 cuda-bindings <tmp-wheel-dir>./ci/tools/validate-release-wheels v12.6.2 cuda-bindings <tmp-wheel-dir>rejects a12.6.2.post1wheel