Make sure CCCL TMA is compiled and use it (very narrowly) - #2428
Open
seberg wants to merge 3 commits into
Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.core
Contributor
Author
|
/ok to test 2c99b8a |
seberg
force-pushed
the
tensor-map-linking
branch
from
July 27, 2026 14:11
2c99b8a to
679bdf5
Compare
1 task
seberg
force-pushed
the
tensor-map-linking
branch
from
July 29, 2026 08:34
679bdf5 to
c640173
Compare
Contributor
Author
|
/ok to test c640173 |
seberg
commented
Jul 29, 2026
| make_tma = _get_cccl_make_tma_fn() | ||
| if (make_tma != NULL | ||
| and device_type == _kDLCUDA | ||
| and box_dim[0] == box_dim[rank - 1] |
Contributor
Author
There was a problem hiding this comment.
This is so restrictive, that I am not sure it still makes sense. But the specific rules also feel too complex to bother with.
(Right now, this path seems useless to me, the only reason to use it and keep it is to exercise it a bit in the hope that it'll be the only path eventually.)
|
In my conda setup, compiling `tensor_map` created linking issues and it seems like the reason this didn't fail here might be that it is missing when it shouldn't be. Adding the `cccl` headers breaks CI the same way, but moving things to `_tensor_map_cccl.pxd` and soft-linking it should then unbreak things again. This now uses CCCL in an *extremely* limited fashion because CCCL has some bugs/issues around validation. (Even if fixed, we still need to support all dtypes in DLPack, though.)
seberg
force-pushed
the
tensor-map-linking
branch
from
August 28, 2026 12:30
c640173 to
0d6e970
Compare
seberg
marked this pull request as ready for review
August 28, 2026 12:31
seberg
changed the title
seberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core issues here is that:
This should be ready for review, two notes though:
try/exceptstyle, so I removed that. Of course thetry/exceptstyle could be used also just try on current CCCL knowing that it is wrong and things will fail most of the time.