Change LIST column offsets from size_type to int32 in benchmarks and gtests - #23682
Change LIST column offsets from size_type to int32 in benchmarks and gtests#23682davidwendt wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (22)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change standardizes list-column offset construction and access on explicit ChangesList offset alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change updates LIST offset types in benchmarks and tests without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Follow on work to #23607 includes changes to
cpp/benchmarksandcpp/testswherecudf::size_typeis used for LIST column offsets and replaced withint32_tinstead.Checklist