-
Notifications
You must be signed in to change notification settings - Fork 208
Java bindings for LP/MIP/QP #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvidiacbrissette
wants to merge
5
commits into
NVIDIA:main
Choose a base branch
from
nvidiacbrissette:cbrissette/cuopt-bindings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9e8fba9
Java bindings for LP/MIP/QP
nvidiacbrissette 9e76c16
removing some logs etc.
nvidiacbrissette c61bb62
many PR updates based on comments.
nvidiacbrissette e8f178d
Fully removed DataModel
nvidiacbrissette 85e5440
Reorganized pr.yaml to avoid conflicts.
nvidiacbrissette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| #!/bin/bash | ||
|
|
||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| RUN_TESTS=false | ||
| if [[ "${1:-}" == "--run-java-tests" ]]; then | ||
| RUN_TESTS=true | ||
| elif [[ $# -gt 0 ]]; then | ||
| echo "Usage: $0 [--run-java-tests]" >&2 | ||
| exit 2 | ||
| fi | ||
|
|
||
| if [[ -e /opt/conda/etc/profile.d/conda.sh ]]; then | ||
| . /opt/conda/etc/profile.d/conda.sh | ||
| fi | ||
|
|
||
| rapids-logger "Configuring conda strict channel priority" | ||
| conda config --set channel_priority strict | ||
|
|
||
| rapids-logger "Downloading the C++ artifact" | ||
| CPP_CHANNEL=$(rapids-download-from-github \ | ||
| "$(rapids-artifact-name conda_cpp libcuopt cuopt --cuda "$RAPIDS_CUDA_VERSION")") | ||
|
|
||
| rapids-logger "Generating Java build dependencies" | ||
| ENV_YAML_DIR=$(mktemp -d) | ||
| rapids-dependency-file-generator \ | ||
| --output conda \ | ||
| --file-key java \ | ||
| --prepend-channel "${CPP_CHANNEL}" \ | ||
| --matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch)" | tee "${ENV_YAML_DIR}/env.yaml" | ||
|
|
||
| rapids-mamba-retry env create --yes -f "${ENV_YAML_DIR}/env.yaml" -n java \ | ||
| --channel "${CPP_CHANNEL}" | ||
|
|
||
| # Temporarily allow unbound variables for conda activation. | ||
| set +u | ||
| conda activate java | ||
| set -u | ||
|
|
||
| rapids-print-env | ||
|
|
||
| export CUOPT_PREFIX="${CONDA_PREFIX}" | ||
| export CUOPT_JAVA_NATIVE_BUILD_DIR="${PWD}/java/cuopt/build/native" | ||
|
|
||
| if [[ "${RUN_TESTS}" == true ]]; then | ||
| rapids-logger "Building and testing the Java bindings" | ||
| bash java/cuopt/scripts/test.sh | ||
| else | ||
| rapids-logger "Building the Java bindings" | ||
| bash java/cuopt/scripts/build_native.sh | ||
| mvn -f java/cuopt/pom.xml clean package \ | ||
| -DskipTests \ | ||
| -Dcuopt.native.dir="${CUOPT_JAVA_NATIVE_BUILD_DIR}" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/bash | ||
|
|
||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| rapids-logger "Checking GPU availability" | ||
| nvidia-smi | ||
|
|
||
| rapids-logger "Running the Java build and tests" | ||
| ci/build_java.sh --run-java-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 713
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 713
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 10559
🏁 Script executed:
Repository: NVIDIA/cuopt
Length of output: 9030
Use the workflow
build_typeforjava-build-matrix..github/workflows/build.yaml:67-70runs on push, tags, and manual nightly dispatch, but this matrix is still hardcoded topull-request, so branch/nightly runs compute the wrong Java matrix.Fix
📝 Committable suggestion
🤖 Prompt for AI Agents