Skip to content

fix(deps): add cufile to test dependencies for cuda12#1553

Open
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:explicit_cufile_test_dep
Open

fix(deps): add cufile to test dependencies for cuda12#1553
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:explicit_cufile_test_dep

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

Description

Testing a smaller base CI image for wheel tests in #1548 -- that image does not
have cuda toolkit installed and we rely on installing all dependencies from
wheels.

In rapidsai/kvikio#1000 and rapidsai/kvikio#1003 we added handling for loading
cufile from an installed wheel -- but we add that dependency to libkvikio
wheels as cuda-toolkit[cufile] and there was no cufile extra available
before cuda-toolkit==12.6.3, so for the testing setup here, we explicitly
install nvidia-cufile-cu12 for earlier versions of cuda-toolkit so that
libcufile is available for tests.

(cuOpt doesn't have a direct dependency on cufile, but instead is running into this in libkvikio via pylibcudf.)

xref rapidsai/build-planning#143

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@gforsyth gforsyth requested a review from a team as a code owner July 10, 2026 15:28
@gforsyth gforsyth added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 10, 2026
@gforsyth gforsyth requested a review from msarahan July 10, 2026 15:28
@gforsyth gforsyth force-pushed the explicit_cufile_test_dep branch from 1e89dcc to c5f8e9b Compare July 10, 2026 15:29
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

@gforsyth gforsyth changed the title fix(deps): add cufile to test dependencies for cuda12 on arm64 fix(deps): add cufile to test dependencies for cuda12 Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d8193079-2b8f-4393-a112-e8cec0629cb5

📥 Commits

Reviewing files that changed from the base of the PR and between 1e89dcc and c5f8e9b.

📒 Files selected for processing (1)
  • dependencies.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • dependencies.yaml

📝 Walkthrough

Walkthrough

Changes

cuFile dependency integration

Layer / File(s) Summary
Configure cuFile test dependency
dependencies.yaml
Adds the test_cufile group for conditional nvidia-cufile-cu12 installation and includes it in the py_test_cuopt environment.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding cufile test dependencies for CUDA 12.
Description check ✅ Passed The description matches the change and explains why the new cufile wheel dependency is needed for tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant