fix(deps): add cufile to test dependencies for cuda12#1553
Open
gforsyth wants to merge 1 commit into
Open
Conversation
1e89dcc to
c5f8e9b
Compare
CI Test Summary✅ All 31 test job(s) passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangescuFile dependency integration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing a smaller base CI image for wheel tests in #1548 -- that image does not
have cuda toolkit installed and we rely on installing all dependencies from
wheels.
In rapidsai/kvikio#1000 and rapidsai/kvikio#1003 we added handling for loading
cufilefrom an installed wheel -- but we add that dependency tolibkvikiowheels as
cuda-toolkit[cufile]and there was nocufileextra availablebefore
cuda-toolkit==12.6.3, so for the testing setup here, we explicitlyinstall
nvidia-cufile-cu12for earlier versions ofcuda-toolkitso thatlibcufileis available for tests.(cuOpt doesn't have a direct dependency on
cufile, but instead is running into this inlibkvikioviapylibcudf.)xref rapidsai/build-planning#143
Checklist