cuopt-skill-evolution: add low-maintenance/fail-loud design rule#1561
Merged
Conversation
…uopt-developer Refactoring the routing DataModel (PR #1556) surfaced recurring maintenance footguns: a hand-maintained list mirroring the Cython wrapper's method surface, and shadow state kept only for a set-time check. Generalize the lesson into a contribution design heuristic that applies to adding any API/layer -- derive from a single source of truth rather than duplicating a surface, and prefer designs that fail loudly (guarded by a coverage test) over ones that silently misbehave. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ramakrishnap-nv
added
non-breaking
Collaborator
Author
|
/nvskills-ci |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe cuOpt developer skill now includes low-maintenance design guidance. Its metadata, references, credential requirements, evaluation records, benchmark values, and signed DSSE bundle were updated. ChangesDeveloper skill updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
CI Test Summary✅ All 0 test job(s) passed. |
Collaborator
Author
|
/ok to test 2ace0f4 |
Iroy30
approved these changes
Jul 13, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a contribution design heuristic (rule 6) to the
cuopt-developerskill: when adding any API or wrapping layer, keep a single source of truth (derive, don't duplicate) and prefer designs that fail loudly over ones that silently misbehave.Generalized from a maintenance issue raised while refactoring the routing DataModel — a hand-maintained list mirroring the wrapper's methods and shadow state kept only for a check.
🤖 Generated with Claude Code