Remove reorder kernel and update installation#83
Conversation
Declare the user-facing simple_packet_reorder launcher from <daqiri/daqiri.h> so consumers do not include private src headers. Keep src/kernels.h private for internal reorder implementation details and make installed pkg-config links resolve sibling DAQIRI libraries. Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
Drop the simple_packet_reorder launcher and its documentation. Keep reordering on the configured rx.reorder_configs path and use a no-op CUDA launch in docs where a generic packet-processing example is useful. Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
8b3fe1c to
4e6cf3e
Compare
|
| Filename | Overview |
|---|---|
| src/kernels.cu | Removed simple_packet_reorder_kernel and its C launcher; remaining packet_reorder_copy_payload_by_sequence and supporting helpers are untouched and still compile cleanly. |
| src/kernels.h | Removed the simple_packet_reorder declaration and dead assert.h include; assert.h is still included directly in kernels.cu, so no build regression. |
| src/CMakeLists.txt | Added INSTALL_RPATH "$ORIGIN" to both daqiri_common and each backend library target so installed .so files can find their sibling libraries at runtime; socket→rdma rule and MGR_LIST handling are unchanged. |
| cmake/daqiri.pc.in | Added -Wl,-rpath-link,${libdir} to the public Libs: field so downstream linkers can resolve libdaqiri's backend .so dependencies at link time; complements the new INSTALL_RPATH $ORIGIN setting. |
| docs/api-guide.md | GPU Packet Aggregation section replaced with GPU Packet Processing; all references to simple_packet_reorder removed and replaced with a generic noop kernel example and pointer to rx.reorder_configs. |
| docs/daqiri-api.html | Sidebar nav entry and method card for simple_packet_reorder removed; HTML is structurally correct after the deletion. |
| docs/index.html | Example card updated from "GPU Packet Reorder Kernel" to "GPU Packet Processing" with matching prose and updated link target to examples/. |
| AGENTS.md | Architecture intro updated to remove the BurstParams* type name in favour of "opaque DAQIRI-owned buffers"; the Zero-copy / BurstParams subsection still names the type explicitly so developer-facing accuracy is preserved. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (base)"]
A["simple_packet_reorder_kernel (kernels.cu)"]
B["simple_packet_reorder extern C (kernels.cu)"]
C["Declaration in kernels.h"]
D["GPU Reorder Kernel docs\n(api-guide.md, daqiri-api.html, index.html)"]
A --> B --> C
B --> D
end
subgraph After["After (HEAD)"]
E["packet_reorder_copy_payload_by_sequence\n(kernels.cu — unchanged)"]
F["INSTALL_RPATH $ORIGIN\n(daqiri_common + backend targets)"]
G["-Wl,-rpath-link,libdir\n(daqiri.pc.in Libs:)"]
F --> G
end
Before -->|"PR removes"| After
E -.->|"still present"| After
Reviews (1): Last reviewed commit: "#81 - Remove public simple reorder kerne..." | Re-trigger Greptile
No description provided.