feat(helm-validate): support Helm version override#53
Merged
Conversation
Signed-off-by: Larry Chen <lachen@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
Downstream integration evidence from NVIDIA/infra-controller#3602:
Existing callers remain on the default Helm |
lachen-nv
marked this pull request as ready for review
July 17, 2026 08:26
lachen-nv
requested review from
abegnoche,
huaweic-nv and
mmou-nv
as code owners
July 17, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
helm-versioninput to the sharedhelm-validateactionv3.13.2as the default for existing callersv3.18.3Why
NVIDIA/infra-controller#3602 validates packaged chart behavior with
helm template --skip-schema-validation. The shared action currently installs Helmv3.13.2, which does not recognize that flag. This allows only the affected callers to opt intov3.18.3without changing all current consumers.This does not add an upstream NGC repository default or change image/AppVersion behavior.
Validation
pre-commit run --files .github/actions/helm-validate/action.yml .github/actions/helm-validate/README.mdv3.13.2andv3.18.3git diff --check