Skip to content

fix(core): restore preferences input label capitalization #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnyanarella merged 1 commit into from
Jul 8, 2026
Merged

fix(core): restore preferences input label capitalization #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/core/.visual/preferences-input.dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions projects/core/.visual/preferences-input.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions projects/core/src/preferences-input/preferences-input.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
flex-direction: column;
}

nve-control,
nve-switch {
--label-text-transform: capitalize;
}

nve-menu {
--width: 100%;
}
10 changes: 10 additions & 0 deletions projects/core/src/preferences-input/preferences-input.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ describe(`${PreferencesInput.metadata.tag}: style check`, () => {
expect(customElements.get(PreferencesInput.metadata.tag)).toBeDefined();
});

it('should capitalize the color scheme label', () => {
const label = element.shadowRoot.querySelector('label');

if (!(label instanceof HTMLLabelElement)) {
throw new Error('Expected a color scheme label');
}

expect(getComputedStyle(label).textTransform).toBe('capitalize');
});

/**
* Test form properties
*/
Expand Down