feat(runtime-v2): add optional native WebM output - #532
Conversation
Greptile SummaryThe PR adds an optional Linux WebM companion package and integrates native VP8/VP9 video plus Opus audio output into runtime-v2 while retaining MP4 as the default.
Confidence Score: 5/5The PR appears safe to merge from the reviewed code perspective, subject to the stated external OSRB prerequisite. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant CLI
participant Factory as Client Window Factory
participant Sink as WebM Output Sink
participant Policy as Codec Policy
participant Native as Native WebM Writer
participant FS as Filesystem
CLI->>Factory: Select --mode webm
Factory->>Sink: Open with SessionDesc
Sink->>Policy: Select VP9 or cached VP8 fallback
Policy-->>Sink: Codec decision
Sink->>Native: Create private staged writer
loop Generated results
Sink->>Native: Encode RGB frames
Sink->>FS: Stage normalized PCM
end
Sink->>Native: Finalize VPx + Opus WebM
Native-->>Sink: Completed staged container
Sink->>FS: Atomically replace destination
Reviews (3): Last reviewed commit: "refactor(runtime-v2): isolate legacy FFm..." | Re-trigger Greptile |
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
e53dadb to
3f08ec2
Compare
Signed-off-by: Jonathan McCaffrey <jmccaffrey@nvidia.com>
|
/ok to test e6c8a74 |
Paralegal OSS-license and codec-patent review (head
|
Summary
flashdreams-webmcompanion wheel whose single native extension statically links checksum-pinned libvpx 1.17.0, libopus 1.6.1, and libwebm 1.0.0.32--mode webmwithout changing the V2 model orAudioOutputAPIs; preserve external-FFmpeg H.264/AAC--mode mp4as the default legacy/native-viewer fallbackThis is stacked on #526 because it consumes that PR's synchronized audio
staging and abort contracts. Retarget it to
mainafter #526 merges.Validation
10 passed(real VP8, VP9, and VP9+Opus containers checked withffprobe)323 passedty: passedreuse lint: REUSE 3.3 compliant, 1291/1291 files classifieduv lock --check, version sync, andgit diff --check: passedThe whole-repository
tycommand still reports existing diagnostics in unrelated docs, WebRTC, Wan, LingBot, and OmniDreams files; no WebM-touched file reports a diagnostic.Merge prerequisite
Because this adds a new optional direct package and statically redistributed third-party libraries, reopen OSRB Bug 6107043 under CONTRIBUTING/OSS policy §14 before merge.