Enable regclient debug logging in gpuop-cfg validation#2190
Open
karthikvetrivel wants to merge 1 commit intoNVIDIA:mainfrom
Open
Enable regclient debug logging in gpuop-cfg validation#2190karthikvetrivel wants to merge 1 commit intoNVIDIA:mainfrom
karthikvetrivel wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
karthikvetrivel
requested review from
cdesiniotis,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rajathagasthya
approved these changes
Mar 6, 2026
tariq1890
reviewed
Mar 6, 2026
| } | ||
|
|
||
| err = validateImages(ctx, &cp.Spec) | ||
| err = validateImages(ctx, &cp.Spec, m.logger) |
Contributor
There was a problem hiding this comment.
How about we initialise registryClient before this method and pass that in as an input parameter instead of logger?
Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
karthikvetrivel
force-pushed
the
fix/gpuop-cfg-regclient-debug-logging
branch
from
fad0123 to
60cdd58
Compare
tariq1890
reviewed
Mar 6, 2026
| ) | ||
|
|
||
| // NewClient creates a regclient client with the provided options. | ||
| func NewClient(opts ...regclient.Opt) *regclient.RegClient { |
Contributor
There was a problem hiding this comment.
Do we need this method at all?
Contributor
There was a problem hiding this comment.
We could just call regclient.New(opts...) directly at the call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wire the existing
--debugflag through to regclient to emit registry auth/token negotiation logs during image validation. Helps diagnose nvcr.io 401 failures in CI.Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Ran
./gpuop-cfg --debug validate csvlocally and confirmed regclient auth debug logs are emitted (token scopes, challenge parsing). Without--debug, no extra output.