Skip to content

Gate dcgm pods on the driver module and probe hostengine GPU visibility #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gengwg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gate dcgm pods on the driver module and probe hostengine GPU visibility #2855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/state-dcgm-exporter/0800_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
- name: toolkit-validation
image: "FILLED BY THE OPERATOR"
command: ['sh', '-c']
args: ["until [ -f /run/nvidia/validations/toolkit-ready ]; do echo waiting for nvidia container stack to be setup; sleep 5; done"]
args: ["until [ -f /run/nvidia/validations/toolkit-ready ] && grep -q '^nvidia ' /proc/modules; do echo waiting for nvidia container stack and driver modules to be setup; sleep 5; done"]
securityContext:
privileged: true
volumeMounts:
Expand Down
17 changes: 13 additions & 4 deletions assets/state-dcgm/0400_dcgm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
- name: toolkit-validation
image: "FILLED BY THE OPERATOR"
command: ['sh', '-c']
args: ["until [ -f /run/nvidia/validations/toolkit-ready ]; do echo waiting for nvidia container stack to be setup; sleep 5; done"]
args: ["until [ -f /run/nvidia/validations/toolkit-ready ] && grep -q '^nvidia ' /proc/modules; do echo waiting for nvidia container stack and driver modules to be setup; sleep 5; done"]
securityContext:
privileged: true
volumeMounts:
Expand All @@ -43,10 +43,19 @@ spec:
ports:
- name: "dcgm"
containerPort: 5555
# A hostengine that started without NVML (e.g. before the driver
# modules were loaded) keeps listening on 5555 but sees no GPUs and
# never re-initialises, so the probe checks GPU visibility.
livenessProbe:
tcpSocket:
port: 5555
initialDelaySeconds: 15
exec:
command:
- sh
- -c
- dcgmi discovery -l | grep -qE '^[1-9][0-9]* GPUs? found'
initialDelaySeconds: 30
periodSeconds: 60
timeoutSeconds: 15
failureThreshold: 3
readinessProbe:
tcpSocket:
port: 5555
Expand Down