fix: Make DSX Exchange MQTT client identifiers unique per process#1720
Merged
ajf merged 2 commits intoMay 18, 2026
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ajf
approved these changes
May 18, 2026
| // (or a new pod coming up while the old one is still terminating) | ||
| // do not race for the same MQTT session and ping-pong each other | ||
| // off the broker. | ||
| let client_id = mqttea::unique_client_id("carbide-dsx-exchange-event-bus"); |
Collaborator
There was a problem hiding this comment.
Worth changing to Nico now. it was already carbide so just a nitpick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my tests of the mqtt integration, the producer and consumer services both used the same client id, this caused them to compete for the client and only one of them was able to connect. This also prevents collisions when running multiple instances of these mqtt clients that connect to a single event bus.