fix: drive storage cleanup through reset before discovery (#5555701)#1748
Open
williampnvidia wants to merge 6 commits into
Open
fix: drive storage cleanup through reset before discovery (#5555701)#1748williampnvidia wants to merge 6 commits into
williampnvidia wants to merge 6 commits into
Conversation
Signed-off-by: Josh P <williamp@nvidia.com>
Signed-off-by: Josh P <williamp@nvidia.com>
9f63f6f to
f96cbec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discovery now leaves destructive storage cleanup to the API-directed reset path
WaitingForCleanupso the state machine can distinguishinitial discovery cleanup from deprovision cleanup and route recovery correctly
WaitingForCleanup { InitialDiscovery }beforereturning Scout
Action::DiscoveryNVMECleanFailedretries so asuccessful retry returns to
HostInit/WaitingForDiscovery, not the deprovision flowboots, and repeated HostInit cleanup failures
Recovery context note
NVMECleanFailedrecovery currently usesFailureSource::StateMachineArea(HostInit)to remember that the failure happened during initial discovery cleanup. That keeps
this fix scoped and avoids changing serialized
FailureCauseshape in this PR.A follow-up should consider storing cleanup context directly on the storage-cleanup
failure cause instead of inferring it from
FailureSource.Dev environment validation
environment and verified the updated pods rolled out
state, Scout
RESET, NVMe cleanup, successfulcleanup_machine_completed,and no destructive cleanup during the later
DISCOVERYhost move through
WaitingForCleanup { InitialDiscovery }, the actual hostreceive
RESET, cleanup complete successfully, thenDISCOVERYlog theno-API cleanup skip message
the machine moved to
NVMECleanFailedmachine recovered from
NVMECleanFailedforce-delete/re-ingest path
Test plan
cargo +1.90.0 fmt --allgit diff --check