feat(configurenmxc): optimize nmxc fabric state#1749
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
narasimhan321
force-pushed
the
nv/improve-nmxcstate
branch
from
6483f17 to
f663d89
Compare
vinodchitrali
left a comment
vinodchitrali
left a comment
There was a problem hiding this comment.
Add migration for state controller
| self.get_firmware_job_status_calls.lock().await.push(cmd); | ||
| pop_or_err(&mut self.get_firmware_job_status_responses.lock().await) | ||
| } | ||
| async fn add_firmware_object( |
| ) -> Result<rms::GetRackFirmwareInventoryResponse, RackManagerError> { | ||
| Ok(rms::GetRackFirmwareInventoryResponse::default()) | ||
| } | ||
| async fn add_firmware_object( |
There was a problem hiding this comment.
seems like its bcz of rms proto related issue
There was a problem hiding this comment.
Yes this is due new rpcs part of pinning latest nvm-rms-client
| return transition_to_rack_error(id, state, "RMS client not configured", ctx) | ||
| .await; | ||
| }; | ||
| let switch_inventory = load_rack_switch_firmware_inventory( |
There was a problem hiding this comment.
time to rename this to load_rack_switch_firmware_inventory - load_rack_switch_inventory
| "Disabling ScaleUpFabric state before selecting ConfigureNmxCluster primary switch" | ||
| ); | ||
| let response = match rms_client | ||
| .set_scale_up_fabric_state(rms::SetScaleUpFabricStateRequest { |
There was a problem hiding this comment.
in ConfigureNmxClusterState::DisableScaleUpFabricState is this correct ?
There was a problem hiding this comment.
is enabled: Some(false), holds the logic ?
There was a problem hiding this comment.
Yes, this is intentional. SetScaleUpFabricStateRequest.enabled is the desired target state, so Some(false) disables ScaleUpFabric state. This state runs before primary selection and sends the request for all switches in the rack.
| Ok(StateHandlerOutcome::transition(RackState::Maintenance { | ||
| maintenance_state: RackMaintenanceState::ConfigureNmxCluster { | ||
| configure_nmx_cluster: | ||
| ConfigureNmxClusterState::ConfigureScaleUpFabricManager, |
There was a problem hiding this comment.
u need to add migration .. What to do if the rack is in WaitForFabricStatus ..
2 participants
Description
Type of Change
Related Issues (Optional)
Testing
Additional Notes