feat(api): auto-transition rack between Ready and Error on component …#1768
Open
vinodchitraliNVIDIA wants to merge 1 commit into
Open
feat(api): auto-transition rack between Ready and Error on component …#1768vinodchitraliNVIDIA wants to merge 1 commit into
vinodchitraliNVIDIA wants to merge 1 commit into
Conversation
…health The Ready handler now scans the rack's switches, power shelves, and machines for terminal failures and transitions the rack to Error with a descriptive cause when any are detected. Conversely, the Error handler promotes the rack back to Ready once every registered component reports Ready, allowing the rack state to reflect component health without manual intervention.
vinodchitraliNVIDIA
force-pushed
the
vc/rack_ready
branch
from
5b0df2b to
a70763f
Compare
kensimon
approved these changes
May 18, 2026
Contributor
kensimon
left a comment
kensimon
left a comment
There was a problem hiding this comment.
Minor nitpick otherwise LGTM
Comment on lines
+76
to
+77
| let txn = ctx.services.db_pool.begin().await?; | ||
| return Ok(StateHandlerOutcome::transition(RackState::Ready).with_txn(txn)); |
Contributor
There was a problem hiding this comment.
Nit: You don't need to start a transaction just to return it here, you can just skip calling with_txn:
Suggested change
| let txn = ctx.services.db_pool.begin().await?; | |
| return Ok(StateHandlerOutcome::transition(RackState::Ready).with_txn(txn)); | |
| return Ok(StateHandlerOutcome::transition(RackState::Ready)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…health
The Ready handler now scans the rack's switches, power shelves, and machines for terminal failures and transitions the rack to Error with a descriptive cause when any are detected. Conversely, the Error handler promotes the rack back to Ready once every registered component reports Ready, allowing the rack state to reflect component health without manual intervention.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes