fix(site-explorer): bail out when Redfish service root vendor is null…#1769
Merged
vinodchitraliNVIDIA merged 1 commit intoMay 18, 2026
Merged
Conversation
… so power shelf chassis fallback runs
wminckler
approved these changes
May 18, 2026
chet
reviewed
May 18, 2026
Comment on lines
+131
to
137
| if service_root.vendor.is_none() { | ||
| return Err(EndpointExplorationError::MissingVendor); | ||
| } | ||
|
|
||
| let Some(vendor) = service_root.vendor() else { | ||
| tracing::info!("No vendor found for BMC at {bmc_ip_address}"); | ||
| return Err(EndpointExplorationError::MissingVendor); |
Contributor
There was a problem hiding this comment.
sorry, lol, double checking my sanity here -- isn't that what this check does right here? and logs that it was missing + returns the same error?
Contributor
There was a problem hiding this comment.
ohhhh.. service_root.vendor vs service_root.vendor() -- oof, lol. maybe drop a comment in there as to why we do this, because that reads soo confusing
Contributor
Author
There was a problem hiding this comment.
in libredifsh .. if none we send unknown. This is causing failure in site explorer fall back code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… so power shelf chassis fallback runs
Some power shelf BMCs (e.g. Lite-On) do not populate the
Vendorfield in the Redfish service root. Previously,
get_redfish_vendor()relied solely on
ServiceRoot::vendor(), which can derive a vendorfrom other hints and mask the missing field. That prevented the
upper-layer fallback in
bmc_endpoint_explorerfrom kicking in toprobe the Chassis
Manufacturerfield for power shelves.Add an explicit check on the raw
service_root.vendorfield andreturn
EndpointExplorationError::MissingVendorearly when it isNone, so the caller can fall back to chassis-based vendor probingfor power shelf endpoints.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes