Skip to content

Update nico_arch_diagram and change it to SVG format#1650

Open
Coco-Ben wants to merge 4 commits into
NVIDIA:mainfrom
Coco-Ben:pgambrill/intro_diagram_update
Open

Update nico_arch_diagram and change it to SVG format#1650
Coco-Ben wants to merge 4 commits into
NVIDIA:mainfrom
Coco-Ben:pgambrill/intro_diagram_update

Conversation

@Coco-Ben
Copy link
Copy Markdown
Contributor

-e
Signed-off-by: Peter Gambrill pgambrill@nvidia.com

Description

Current version is out of date, and also doesn't scale well.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

-e
Signed-off-by: Peter Gambrill <pgambrill@nvidia.com>
@Coco-Ben Coco-Ben requested a review from andreliuNV May 14, 2026 17:25
Copy link
Copy Markdown
Contributor

Review findings from the technical accuracy pass. I think this still needs changes before merge.

Blocker:

  • The added SVG appears to include browser-extension injected JavaScript at the top: a <script type="application/ecmascript"> block that references navigator.geolocation, overrides Blob, and calls chrome.runtime. Please regenerate or sanitize the SVG so it contains only static diagram content.

Issue #1192 coverage:

  • Temporal is still only an edge label, appears misspelled as Termporal, and is not modeled as a visible prerequisite box alongside PostgreSQL/Vault.
  • I do not see NTP/chrony represented, even though the agent resolves carbide-ntp.forge and DHCP sends NTP servers.
  • Persona entry points are still shown as specific clients rather than grouped by Operators/Tenants/Automation/Monitoring or the docs personas.
  • Route Server no longer appears as a NICo-deployed Helm component, which is directionally correct, but I do not see an external optional route server/peering entity, so that item is only partially addressed.

I ran fern check --warnings on the PR head: 0 errors, with 2 unrelated warnings already present in the docs setup (unauthenticated redirects check skipped and the existing light-mode accent contrast warning).

- Also remove ecmascript from SVG code

Signed-off-by: Peter Gambrill <pgambrill@nvidia.com>
@Coco-Ben Coco-Ben force-pushed the pgambrill/intro_diagram_update branch from 732f67b to 38fc39f Compare May 21, 2026 00:54
@github-actions
Copy link
Copy Markdown

@Coco-Ben Coco-Ben enabled auto-merge (squash) May 21, 2026 17:11
@ajf
Copy link
Copy Markdown
Collaborator

ajf commented May 21, 2026

@Coco-Ben this is missing:

  • Missing NICo Flow (formerly RLA) cc @zhaozhongn

  • Missing NVLink (@tmcroberts97) & Spectrum-X (@srinivasadmurthy)

  • Add line from Hardware Health -> DPU BMC

  • Add line from PXE service <- DPU OOB

  • Add line from SSH Console Service -> DPU BMC

otherwise lgtm without looking too busy

@SiamakNa
Copy link
Copy Markdown

Take out the Admin CLI and Admin Web Browser lines they are not end user interfaces.
Make the DPU box to the lower right, as being optional component (for the 0-dpu use case).
We are working and SVPC and Astra, not checked in but we need to update this when Astra and SVPC has been added.

@ajf
Copy link
Copy Markdown
Collaborator

ajf commented May 21, 2026

Take out the Admin CLI and Admin Web Browser lines they are not end user interfaces.

Probably we should leave it in until the code is removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants