bmc-proxy: Support endpoints by mac or serial#1874
Open
kensimon wants to merge 4 commits into
Open
Conversation
DPS uses bmc-proxy to get relevant information for BMC's, but it only has access to mac addresses and serial numbers, not the BMC's IP address. They were going to need to make their own API calls to nico in order to look up the IP address. Instead, support looking up by mac addresses or serial numbers directly in the `Forwarded:` header.
yoks
approved these changes
May 21, 2026
zhaozhongn
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DPS uses bmc-proxy to get relevant information for BMC's, but it only has access to mac addresses and serial numbers, not the BMC's IP address. They were going to need to make their own API calls to nico in order to look up the IP address. Instead, support looking up by mac addresses or serial numbers directly in the
Forwarded:header.Type of Change
Breaking Changes
Testing
Additional Notes