fix(admin-cli): accept RPC UUID IDs in expected machine JSON#3338
Draft
behroozrafii wants to merge 1 commit into
Draft
fix(admin-cli): accept RPC UUID IDs in expected machine JSON#3338behroozrafii wants to merge 1 commit into
behroozrafii wants to merge 1 commit into
Conversation
Signed-off-by: Behrooz Rafii <brafii@nvidia.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix expected-machine JSON imports when
idis serialized as an RPC UUID object instead of a plain string.The importer now accepts missing IDs, string IDs, and object IDs such as
{"value":"..."}.Related issues
Fixes #1877
Type of Change
Breaking Changes
Testing
cargo fmt --all -- --checkcargo test -p nico-admin-cli- 374 passedAdditional Notes
This restores compatibility with JSON exported by the CLI and then supplied to
replace-all.