Skip to content

fix(admin-cli): accept RPC UUID IDs in expected machine JSON#3338

Draft
behroozrafii wants to merge 1 commit into
NVIDIA:mainfrom
behroozrafii:behrooz/1877-expected-machine-json-id
Draft

fix(admin-cli): accept RPC UUID IDs in expected machine JSON#3338
behroozrafii wants to merge 1 commit into
NVIDIA:mainfrom
behroozrafii:behrooz/1877-expected-machine-json-id

Conversation

@behroozrafii

Copy link
Copy Markdown

Fix expected-machine JSON imports when id is serialized as an RPC UUID object instead of a plain string.

The importer now accepts missing IDs, string IDs, and object IDs such as {"value":"..."}.

Related issues

Fixes #1877

Type of Change

  • Fix - Bug fixes

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated

cargo fmt --all -- --check
cargo test -p nico-admin-cli - 374 passed

Additional Notes

This restores compatibility with JSON exported by the CLI and then supplied to replace-all.

Signed-off-by: Behrooz Rafii <brafii@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8490e87d-d02e-4837-987c-1bf088733f86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@copy-pr-bot

copy-pr-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: The json file produced using carbide-admin-cli can no longer be pushed back in the site using the command's "replace-all" feature

1 participant