vgpu: skip malformed vendor capability records instead of panicking#1912
Open
AruneshDwivedi wants to merge 1 commit into
Open
vgpu: skip malformed vendor capability records instead of panicking#1912AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
GetVendorSpecificCapability sliced the PCI config buffer using a length byte read from config space without checking pos+length against len(d.Config), so a malformed record panicked gpu-feature-discovery and crashed the node's GFD refresh loop. Guard the slice and skip the record so one bad device can't take down the whole process. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetVendorSpecificCapability sliced the PCI config buffer with a length byte read from config space and no bounds check, so a malformed record panicked gpu-feature-discovery and broke GFD refresh for the whole node. It now skips the bad record so one device can't crash the process.
Used AI to help identify and draft this fix — reviewed and tested before submitting.