fix(worker): add missing go.sum entries, restore clean build#232
Open
mesutoezdil wants to merge 2 commits into
Open
fix(worker): add missing go.sum entries, restore clean build#232mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
go.sum was missing the go.mod hash lines for klauspost/compress v1.18.5 and pelletier/go-toml/v2 v2.3.0 (only the module hash was present for each). go build ./... fails outright with "missing go.sum entry for go.mod file" on any checkout that does not already have these modules warm in the local module cache, which includes a clean CI runner. Added both with go mod download; no go.mod change. Verified with go build, go vet, and go test ./... (all packages pass). NO-REF Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/libraries/go/worker/go.sum was missing the go.mod hash line for two transitive deps (klauspost/compress v1.18.5, pelletier/go-toml/v2 v2.3.0). go build failed on any environment without those already cached.
Tested: go build, go vet, go test ./... pass for every package. go.mod untouched, only go.sum changed.
Refs: NO-REF