Skip to content

Update codeowners#1378

Open
coreyjadams wants to merge 2 commits intoNVIDIA:mainfrom
coreyjadams:update-codeowners-v2.0
Open

Update codeowners#1378
coreyjadams wants to merge 2 commits intoNVIDIA:mainfrom
coreyjadams:update-codeowners-v2.0

Conversation

@coreyjadams
Copy link
Collaborator

PhysicsNeMo Pull Request

Update codeowners for the new repository structure.

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@coreyjadams coreyjadams self-assigned this Feb 5, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 5, 2026

Greptile Overview

Greptile Summary

Restructured CODEOWNERS file with improved organization and comprehensive coverage across the repository structure.

Major changes:

  • Reorganized from loose grouping to clear sections (top-level files, core framework, infrastructure, models, examples, tests)
  • Added extensive ownership mappings for previously unowned directories and files
  • Assigned owners to AFNO, FNO, RNN, SRRN, Pix2Pix, TopoDiff models that were previously marked as NEEDSOWNER
  • Expanded coverage of examples across multiple domains (CFD, weather, healthcare, structural mechanics, etc.)
  • Added detailed test ownership mappings matching source structure
  • Improved documentation with section headers and better comments

Issues found:

  • Line 73: Duplicate @loliverhennigh owner
  • Line 202: References non-existent physicsnemo/models/gnn_layers/ directory (was moved to physicsnemo/nn/module/gnn_layers/ in V2.0 refactor but CODEOWNERS wasn't updated)

Important Files Changed

Filename Overview
.github/CODEOWNERS Comprehensive restructuring of CODEOWNERS with better organization and more granular ownership; found duplicate owner and stale directory reference

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

physicsnemo/nn/functional/ @loliverhennigh
physicsnemo/nn/functional/knn/ @coreyjadams @peterdsharpe @loliverhennigh
physicsnemo/nn/functional/radius_search/ @coreyjadams @peterdsharpe @loliverhennigh
physicsnemo/nn/functional/sdf.py @RishikeshRanade @loliverhennigh @loliverhennigh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loliverhennigh listed twice

Suggested change
physicsnemo/nn/functional/sdf.py @RishikeshRanade @loliverhennigh @loliverhennigh
physicsnemo/nn/functional/sdf.py @RishikeshRanade @loliverhennigh

physicsnemo/models/fno/ @ktangsali

# GraphCast and GNN
physicsnemo/models/gnn_layers/ @mnabian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

physicsnemo/models/gnn_layers/ doesn't exist anymore - was moved to physicsnemo/nn/module/gnn_layers/ (already covered on line 77)

Suggested change
physicsnemo/models/gnn_layers/ @mnabian
# GNN layers moved to physicsnemo/nn/module/gnn_layers/

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants