Skip to content

fix: libraft output declares unused C compiler - #3114

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-output-declares-unused-c
Open

fix: libraft output declares unused C compiler#3114
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-output-declares-unused-c

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in conda/recipes/libraft/recipe.yaml: libraft output declares unused C compiler.

Changes

  • conda/recipes/libraft/recipe.yaml: libraft output declares unused C compiler.

Details

--- a/conda/recipes/libraft/recipe.yaml
+++ b/conda/recipes/libraft/recipe.yaml
@@ -1,16 +1,15 @@
-  - package:
-      name: libraft
-      version: ${{ version }}
-    build:
-      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
-      dynamic_linking:
-        overlinking_behavior: "error"
-      script:
-        content: |
-          cmake --install cpp/build --component compiled
-    requirements:
-      build:
-        - cmake ${{ cmake_version }}
-        - ${{ compiler("c") }}
-      host:
-        - ${{ pin_subpackage("libraft-headers", exact=True) }}
+  - package:
+      name: libraft
+      version: ${{ version }}
+    build:
+      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
+      dynamic_linking:
+        overlinking_behavior: "error"
+      script:
+        content: |
+          cmake --install cpp/build --component compiled
+    requirements:
+      build:
+        - cmake ${{ cmake_version }}
+      host:
+        - ${{ pin_subpackage("libraft-headers", exact=True) }}

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw requested a review from a team as a code owner August 13, 2026 01:34
@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 098ad6d0-7024-4b91-90a4-91db61c3dbab

📥 Commits

Reviewing files that changed from the base of the PR and between e2437c4 and 1da4bd4.

📒 Files selected for processing (1)
  • conda/recipes/libraft/recipe.yaml
💤 Files with no reviewable changes (1)
  • conda/recipes/libraft/recipe.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Streamlined the libraft package build configuration by removing an unnecessary build requirement.
    • Package outputs and runtime dependencies remain unchanged.

Walkthrough

The libraft package recipe removes the C compiler from its build requirements. Other outputs and dependencies remain unchanged.

Changes

Cohort / File(s) Summary
libraft build requirements
conda/recipes/libraft/recipe.yaml
Removes the C compiler from the package build requirements.
Estimated code review effort: 1 (Trivial) ~2 minutes

Mergeability Score: ⚪ Minimal · up to 1da4b

This localized packaging change removes an unused compiler declaration and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: kylefromnvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the libraft output and the removal of its unused C compiler declaration.
Description check ✅ Passed The description accurately explains the change and includes the affected file and diff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant